Add tests for percentage validation

learningequality · Mar 22, 2022 · 6a0dffd · 6a0dffd
1 parent 4ec40e1
commit 6a0dffd
Showing 1 changed file with 36 additions and 0 deletions.
diff --git a/tests/test_schemas.py b/tests/test_schemas.py
@@ -122,6 +122,23 @@ def test_completion_criteria__pages_model__valid():
         )
 
 
+@pytest.mark.skipif(jsonschema is None, reason="jsonschema package is unavailable")
+def test_completion_criteria__pages_model__percentage__valid():
+    with _assert_not_raises(jsonschema.ValidationError):
+        _validate(
+            {
+                "model": "pages",
+                "threshold": "99%",
+            }
+        )
+        _validate(
+            {
+                "model": "pages",
+                "threshold": "1%",
+            }
+        )
+
+
 @pytest.mark.skipif(jsonschema is None, reason="jsonschema package is unavailable")
 def test_completion_criteria__pages_model__invalid():
     with pytest.raises(jsonschema.ValidationError):
@@ -141,6 +158,25 @@ def test_completion_criteria__pages_model__invalid():
         )
 
 
+@pytest.mark.skipif(jsonschema is None, reason="jsonschema package is unavailable")
+def test_completion_criteria__pages_model__percentage__invalid():
+    with pytest.raises(jsonschema.ValidationError):
+        _validate(
+            {
+                "model": "pages",
+                "threshold": "0%",
+                "learner_managed": False,
+            }
+        )
+    with pytest.raises(jsonschema.ValidationError):
+        _validate(
+            {
+                "model": "pages",
+                "threshold": "101%",
+            }
+        )
+
+
 @pytest.mark.skipif(jsonschema is None, reason="jsonschema package is unavailable")
 def test_completion_criteria__mastery_model__valid():
     with _assert_not_raises(jsonschema.ValidationError):