Tests uKResponsiveWindow composable and Updates KDS Package to latest develop

[akolson]

Summary

This pr implements the useKResponsiveWindow composable in areas where its mixin equivalent(KResponsiveWindowMixin) is used particularly in kolibri/plugins/learn/assets/src/views/LibraryPage/SidePanel.vue and kolibri/plugins/learn/assets/src/views/LibraryPage/index.vue as a test.

Please note that my KDS fork has been referenced for testing purposes. This will be reverted once KDS PR learningequality/kolibri-design-system#377 gets merged

References

learningequality/kolibri-design-system#377

Reviewer guidance

1. Navigate to http://localhost:8000/en/learn/#/library
2. Test the window for responsiveness. It should behave as before when using the mixin

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0.dev0_git.20221018181443.pex
Unsigned Windows installer	kolibri-0.16.0.dev0+git.20221018181443-unsigned.exe
Debian Package	kolibri_0.16.0.dev0+git.20221018181443-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0.dev0+git.20221018181443-0.3.0.dmg
Source Tarball	kolibri-0.16.0.dev0+git.20221018181443.tar.gz
WHL file	kolibri-0.16.0.dev0+git.20221018181443-py2.py3-none-any.whl

[radinamatic]

Tested by running from the source with Firefox on Ubuntu, no regressions on the Learn/Library page when resizing the window, neither manually nor with the Responsive Design Mode.

@pcenov Could you grab the Windows asset and test with Chrome? Thank you!

[pcenov]

Hi @akolson and @radinamatic the main regression I see is that the Library page cannot be opened any more in Internet Explorer:

I couldn't find any other issues in the rest of the supported browsers, but I do have plenty reported here: #9726

[radinamatic]

Library page cannot be opened any more in Internet Explorer

Oouch, thank you for fishing that out, I tend to forget IE11 (wishful thinking, I know 😒)

[akolson]

Great catch @pcenov. Fixing this. Thanks

[akolson]

@radinamatic @pcenov. The issue with IE should be resolved now!

[pcenov]

@akolson I confirm that now the Library page can be opened in IE however the responsiveness is not functioning correctly. For example if I shrink the window while at the Library page the filters section never goes in mobile view, while if I go in mobile view and then expand the window the filters section doesn't go back to desktop mode:

2022-10-13_11-03-12.mp4

[akolson]

Hi @pcenov, Thanks for the feedback. I have fixed the issues with responsiveness on IE so we should be good now!

[pcenov]

Awesome @akolson - everything looks fine now in all supported browsers! :)

[radinamatic]

Manual QA passes, good to go! 💯

[akolson]

PR has been updated to the latest KDS commit