Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add content check guard to library page #9635

Conversation

marcellamaki
Copy link
Member

Summary

Adds the same check for content that is used on /home to /library

References

Fixes #9625
Screen Shot 2022-08-18 at 9 16 44 AM

Reviewer guidance

  1. Create a new facility with no resources added
  2. navigate to the /library page
  3. Rather than seeing a constant loading state, you should see the screen above

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@marcellamaki marcellamaki requested a review from rtibbles August 18, 2022 13:34
@marcellamaki marcellamaki added the TODO: needs review Waiting for review label Aug 18, 2022
@marcellamaki marcellamaki marked this pull request as ready for review August 18, 2022 13:34
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right fix to me.

I can't get the log to load from the test failure - if you don't see any frontend test failures locally, then just rerun the test and merge.

@rtibbles rtibbles linked an issue Aug 19, 2022 that may be closed by this pull request
@rtibbles rtibbles merged commit 4f86ee6 into learningequality:release-v0.15.x Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add guard to /library when no resources are added.
2 participants