Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Applies to the common strings modules the pattern @rtibbles noted here where they will export a getter function as well as the mixin for the case in which one wants to just get a string not in the context of a Vue component.
Some i18n follow-up is needed in general. This pattern could be extended to some of our other string definitions files - but this will make a bit of that easier to do.
Follow-up issue: TBD
I also added documentation re: our common modules - not sure if this is any good or helpful, very much open to feedback on this.
References
Reviewer guidance
Is there room for regression I'm not seeing?
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)