Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bottom bar text in lesson resources to say save on changes #9516

Conversation

marcellamaki
Copy link
Member

Summary

When resourcesChanged is true on the Mange Lesson Resources page, the button changes to say "save" instead of "close". It stays "close" when navigating through the folder structure, or when there are no changes.

References

Fixes #9473

Reviewer guidance

  1. Navigate through the "manage lesson resources" flow
  2. "Close" should appear by default
  3. Selecting and/or deselecting resources should change the button to save
save-vs-close.mp4

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@marcellamaki marcellamaki added the TODO: needs review Waiting for review label Jun 14, 2022
@marcellamaki marcellamaki added this to the Planned Patch 4: Coach usability improvements milestone Jun 14, 2022
@radinamatic
Copy link
Member

Two suggestions for improvements:

  1. Change the string on the initial lesson creation page (title & recipients) from Save changes to Save, so it's consistent with the steps in Manage resources.
  2. If a resource is selected, the button changes from Close to Save, but if that same resource is removed, the button still says Save. Shouldn't it return to Close, given that there are no changes to save?

save

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm!

…n same interaction, change to close rather than save
@marcellamaki
Copy link
Member Author

@radinamatic - updated! Let me know if this is what you were thinking

@radinamatic
Copy link
Member

Yey, Save changes and Close are now switching back and forth as required! 💯

Tested by running from the source, let's figure out why the build is failing before merging.

save

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passed, just the build is failing.

@rtibbles
Copy link
Member

This only changed JS code, and the JS part of the build completed successfully. The Python failure is fixed in the release-v0.15.x branch, so this is safe to merge.

@rtibbles rtibbles merged commit ce0f976 into learningequality:release-v0.15.x Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants