-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bottom bar text in lesson resources to say save on changes #9516
Update bottom bar text in lesson resources to say save on changes #9516
Conversation
… resources changed
Two suggestions for improvements:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm!
…n same interaction, change to close rather than save
@radinamatic - updated! Let me know if this is what you were thinking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passed, just the build is failing.
This only changed JS code, and the JS part of the build completed successfully. The Python failure is fixed in the release-v0.15.x branch, so this is safe to merge. |
Summary
When
resourcesChanged
is true on the Mange Lesson Resources page, the button changes to say "save" instead of "close". It stays "close" when navigating through the folder structure, or when there are no changes.References
Fixes #9473
Reviewer guidance
save-vs-close.mp4
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)