Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination user tables #9450

Conversation

marcellamaki
Copy link
Member

Summary

Updates handler.js for the class enrollment user management, and simplifies the vue components to better match the updates in the FacilityUsers page. Now learners should be accurately displaying in the user table for enrollment in a class.

References

Fixes #9448
learners

Reviewer guidance

Is the pagination working as expected with > 30 users?

Also... am I supposed to be filtering out anyone not exclusively a learner? Truly cannot remember.... I think coaches and admins can still be added to classes


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@marcellamaki marcellamaki requested a review from rtibbles May 18, 2022 21:32
@marcellamaki marcellamaki added the TODO: needs review Waiting for review label May 18, 2022
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense from an initial read through - one question though.

@marcellamaki marcellamaki requested a review from radinamatic May 19, 2022 21:39
@radinamatic
Copy link
Member

radinamatic commented May 19, 2022

30< Learners are back! 🥳

Tested on Chrome & Firefox on Windows 10

2022-05-20_0-22-08

And yes, filtering is only in play when assigning coaches, anybody can be a learner 🙂

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏽 :shipit:

@radinamatic
Copy link
Member

Re-tested on Win 10 after the last commits by @rtibbles, 30< learner pagination still looking good, let's merge for the bugbash tomorrow!

2022-05-20_2-25-17

@radinamatic radinamatic merged commit 990f5b5 into learningequality:release-v0.15.x May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants