-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pagination user tables #9450
Fix pagination user tables #9450
Conversation
…st the first page on every update
…date props to work with this approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to make sense from an initial read through - one question though.
kolibri/plugins/facility/assets/src/modules/classAssignMembers/handlers.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏽
Re-tested on Win 10 after the last commits by @rtibbles, 30< learner pagination still looking good, let's merge for the bugbash tomorrow! |
Summary
Updates
handler.js
for the class enrollment user management, and simplifies the vue components to better match the updates in the FacilityUsers page. Now learners should be accurately displaying in the user table for enrollment in a class.References
Fixes #9448
Reviewer guidance
Is the pagination working as expected with > 30 users?
Also... am I supposed to be filtering out anyone not exclusively a learner? Truly cannot remember.... I think coaches and admins can still be added to classes
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)