Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shrink ray from TopicsPage content side panel #9449

Merged

Conversation

nucleogenesis
Copy link
Member

Summary

Fixes #9347 wherein the View Resource link from the metadata side panel on the Topics page would cause the content you navigate to being shrunken and squeezed.

The issue was that in order to avoid the content underneath the side panel scrolling when scrolling within the modal side panel, we watch the value that triggers the opening of the modal. In that watcher, it sets the html.style.position to 'fixed', which remains through router navigation and caused the entire tag to be smushed.

The fix was to unset it in the beforeDestroy hook in TopicsPage - I added some comments to explain the behavior.

References

Fixes #9434

Reviewer guidance

Go to a Topics page, open a content item's side panel, click "View Resource" and see the content in the expected form.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@nucleogenesis nucleogenesis added the TODO: needs review Waiting for review label May 18, 2022
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @nucleogenesis

@marcellamaki marcellamaki merged commit e9c1458 into learningequality:release-v0.15.x May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants