Remove shrink ray from TopicsPage content side panel #9449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9347 wherein the View Resource link from the metadata side panel on the Topics page would cause the content you navigate to being shrunken and squeezed.
The issue was that in order to avoid the content underneath the side panel scrolling when scrolling within the modal side panel, we watch the value that triggers the opening of the modal. In that watcher, it sets the html.style.position to 'fixed', which remains through router navigation and caused the entire tag to be smushed.
The fix was to unset it in the
beforeDestroy
hook in TopicsPage - I added some comments to explain the behavior.References
Fixes #9434
Reviewer guidance
Go to a Topics page, open a content item's side panel, click "View Resource" and see the content in the expected form.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)