Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mac app pipeline #9257

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 8, 2022

Summary

Disables the mac app buildkite pipeline trigger. All mac app assets must now be manually built using the Github Action workflow on the repository.

References

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles changed the base branch from develop to release-v0.15.x April 8, 2022 15:09
@rtibbles rtibbles changed the base branch from release-v0.15.x to release-v0.15.2 April 12, 2022 18:14
@rtibbles rtibbles changed the title Mac app upgrade Disable mac app pipeline Apr 14, 2022
@rtibbles rtibbles marked this pull request as ready for review April 14, 2022 16:25
@DXCanas
Copy link
Member

DXCanas commented Apr 25, 2022

LGTM! as long as all the other GHA pieces are in place?

@rtibbles
Copy link
Member Author

Yeah, we'll be manually building any Mac assets via the Github Action manual workflow now.

@rtibbles rtibbles merged commit c49e6bd into learningequality:release-v0.15.2 Apr 25, 2022
@rtibbles rtibbles deleted the mac_app_upgrade branch April 25, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants