Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURE_CONTENT_TYPE_NOSNIFF setted to True #9195

Merged
merged 1 commit into from
Mar 16, 2022
Merged

SECURE_CONTENT_TYPE_NOSNIFF setted to True #9195

merged 1 commit into from
Mar 16, 2022

Conversation

sakshampathak1508
Copy link
Contributor

@sakshampathak1508 sakshampathak1508 commented Mar 15, 2022

Fixes issue number #9033
updated base.py and updated SECURE_CONTENT_TYPE_NOSNIFF to True

Summary

References

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

updated base.py and updated SECURE_CONTENT_TYPE_NOSNIFF to True
@rtibbles
Copy link
Member

Thanks, this looks like the right fix!

Could you please add a reference to the issue that this is fixing?

Can say Fixes #<github issue number> in the pull request description.

@sakshampathak1508
Copy link
Contributor Author

Hello added the issue number for the fix in the PR description

@rtibbles rtibbles linked an issue Mar 15, 2022 that may be closed by this pull request
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - we'll do some manual QA to confirm that this does what we expect!

@sakshampathak1508
Copy link
Contributor Author

cool thanks for guiding me. on to more issues

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA confirms!

@rtibbles rtibbles merged commit bb3b965 into learningequality:release-v0.15.x Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set SECURE_CONTENT_TYPE_NOSNIFF setting to True
2 participants