Modify retrying of sync tasks to use resumesync command #9170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjester
commented
Mar 9, 2022
| @@ -111,12 +109,7 @@ | |||
| if (this.taskInfo.canCancel) { | |||
| return 'cancel'; | |||
| } else if (this.taskInfo.canClear) { | |||
| // Import tasks can't be retried since we don't save the username/password | |||
There was a problem hiding this comment.
This comment was incorrect. The credentials are validated prior to the creation of the task, and once validated, a certificate is created which facilitates authentication thereafter
marcellamaki
modified the milestones:
Planned Patch: "Clear the decks",
Planned Patch 3: TBD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
…
References
Addresses #7270
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarnandpip)