Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump morango to v0.6.10 #9168

Merged

Conversation

bjester
Copy link
Member

@bjester bjester commented Mar 8, 2022

Summary

  • Upgrades morango version to v0.6.10 containing these fixes

References

Reviewer guidance

  1. Set up a Debian/Ubuntu VM
sudo apt install postgresql python3-psycopg2
wget "https://github.com/learningequality/kolibri/releases/download/v0.15.0/kolibri_0.15.0-0ubuntu1_all.deb"
sudo apt install ./kolibri_0.15.0-0ubuntu1_all.deb
sudo su postgres -c psql
# Run the following SQL
CREATE DATABASE kolibri;
CREATE ROLE kolibri WITH LOGIN PASSWORD 'kolibri';
GRANT CONNECT ON DATABASE kolibri TO kolibri;
\c kolibri
GRANT ALL PRIVILEGES ON SCHEMA public TO kolibri;
GRANT SELECT, INSERT, UPDATE, DELETE, REFERENCES, TRIGGER ON ALL TABLES IN SCHEMA public TO kolibri;
GRANT ALL PRIVILEGES ON ALL SEQUENCES IN SCHEMA public TO kolibri;
# end SQL
  1. Edit ~/.kolibri/options.ini:
[Database]
DATABASE_ENGINE = postgres
DATABASE_NAME = kolibri
DATABASE_PASSWORD = kolibri
DATABASE_USER = kolibri
DATABASE_HOST = 127.0.0.1
DATABASE_PORT = 5432
  1. Restart Kolibri
sudo systemctl restart kolibri.service
  1. Open a web browser and proceed through setup wizard (if running a headless VM, you'll probably need to add port forwarding from your host to the VM)
  2. On the VM, upgrade Kolibri
wget "https://github.com/learningequality/kolibri/releases/download/v0.15.1/kolibri_0.15.1-0ubuntu1_all.deb"
sudo apt install ./kolibri_0.15.1-0ubuntu1_all.deb
  1. Check the transfer table:
sudo su postgres -c 'psql -c "\d morango_transfersession" kolibri' | grep transfer_stage
  1. You should see the issue, that the column fields are not null
  2. Install this change
wget -O pr.deb "https://buildkite.com/organizations/learningequality/pipelines/kolibri-debian/builds/3904/jobs/1d46cbf9-3319-4a3b-a261-ff6d6bba66e1/artifacts/6df892fe-6cad-490c-a5a9-12a92268b2c8"
sudo apt install ./pr.deb
  1. Check the transfer table:
sudo su postgres -c 'psql -c "\d morango_transfersession" kolibri' | grep transfer_stage
  1. The columns should no longer be not null

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester linked an issue Mar 8, 2022 that may be closed by this pull request
@bjester bjester added DEV: backend Python, databases, networking, filesystem... P0 - critical Priority: Release blocker or regression TAG: dependencies Pull requests that update a dependency file TODO: needs review Waiting for review labels Mar 8, 2022
@bjester bjester added this to the 0.15.2 milestone Mar 8, 2022
@rtibbles rtibbles self-requested a review March 10, 2022 21:05
@rtibbles
Copy link
Member

Hrm - I don't actually see any replication at step 6, I think because the TransferSession table is empty. Will attempt to put some records in on Monday.

@bjester
Copy link
Member Author

bjester commented Mar 12, 2022

@rtibbles The command at step 6 I shared should describe the table's schema so no data should be required.

@rtibbles
Copy link
Member

Ah, I probably forgot to install latest postgresql, as I took a slight shortcut and tested this outside of a VM.

@rtibbles
Copy link
Member

On a fresh VM was able to replicate and confirm. For posterity, it required one more restart after the installation of the PR asset.

@rtibbles rtibbles merged commit d9be047 into learningequality:release-v0.15.x Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... P0 - critical Priority: Release blocker or regression TAG: dependencies Pull requests that update a dependency file TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotNullViolation when trying to import a learner account
2 participants