Redirect for Bookmarks when user is not logged in

[sairina]

Summary

Added a check to see whether or not a user is logged in. If a user is not logged in, they are redirected to the "content unavailable" view.

References

Fixes #9057

Reviewer guidance

Follow the guidance from the original issue:

1. Select "Allow users to explore resources without signing in" in device settings as an admin
2. Sign out
3. Type /en/learn/#/bookmarks URL to the browser address bar
4. Make sure that you see the image below

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[pcenov]

Seems that this is partially fixed because navigating to /en/learn/#/bookmarks as a signed out user results in the user seeing the /en/learn/#/resources-unavailable page while as pointed out above the expected result is for the user to see /en/device/#/permissions.

Observed:

Expected:

[MisRob]

I can confirm, I was just in the middle of the review when I saw this too.

Also, after this is resolved, we also need to make sure that for "Allow users to explore resource without signing in" device settings, users will get redirected to the bookmarks page after they sign in. This can be achieved by using the next query parameter similarly it's currently done for "Learners must sign in to explore resources" device settings (see next=http%253A%252F%252F127.0.0.1%253A8000%252Fen%252Flearn%252F%2523%252Fbookmarks in the URL)

[MisRob]

Thank you, @sairina, it's definitely better than it was. It would be good to resolve the issues mentioned above before merging.

[rtibbles]

I think this is best targeted in LearnIndex at the moment, not in the router - router guards are best used to redirect to other pages, not conditionalize behaviour within a page.

[sairina]

With the changes, this is the behavior:

User (not logged in) goes to /learn/#/bookmarks and clicks on "sign in" link	User is able to sign in (note the update in the URL)

[rtibbles]

Delightfully simple!

Changes addressed!