Add check for notification
to avoid il8n error in CoreBase
#9138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Presently, there is an existing error in
CoreBase
aroundUpdateNotification
with themostRecentNotification
computed prop returningundefined
and rendering an error because nonotification
existed. This error was discovered when writing tests forNotificationsRoot
, and can be seen here through use of Vue dev tools and being able to log this error to the console - otherwise, this fails silently.Note: any changes here will also need to be reflected in this PR: #9128. That PR is targeted for 0.16, but it might make sense for us to fix this in 0.15.
References
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)