Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for notification to avoid il8n error in CoreBase #9138

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

sairina
Copy link
Contributor

@sairina sairina commented Feb 24, 2022

Summary

Presently, there is an existing error in CoreBase around UpdateNotification with the mostRecentNotification computed prop returning undefined and rendering an error because no notification existed. This error was discovered when writing tests for NotificationsRoot, and can be seen here through use of Vue dev tools and being able to log this error to the console - otherwise, this fails silently.

Note: any changes here will also need to be reflected in this PR: #9128. That PR is targeted for 0.16, but it might make sense for us to fix this in 0.15.

References

Screen Shot 2022-02-23 at 4 02 44 PM

Reviewer guidance

  • Please make sure this does not affect other parts of the codebase where we do have notifications, thanks!

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@sairina sairina requested a review from rtibbles February 24, 2022 00:09
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple defensive programming guard. Very good.

@rtibbles rtibbles merged commit 2f97980 into learningequality:release-v0.15.x Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants