Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings for Python 3.4 and 3.5 #9113

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Feb 15, 2022

Summary

  • Sets up a logger with pretty colors for our env.py file (using the same color config as our regular logger)
  • Adds a deprecation warning for Python versions 3.4 and 3.5 which gets logged as a warning and emitted as a Python warning

Reviewer guidance

Run kolibri with Python 3.4 and 3.5, confirm that a warning appears on the terminal.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Feb 15, 2022
@rtibbles rtibbles added this to the 0.15.1 milestone Feb 15, 2022
@rtibbles rtibbles requested review from bjester and jredrejo February 15, 2022 00:18
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested with 2.7 & 3.8 without any issue

@marcellamaki marcellamaki merged commit bce179a into learningequality:release-v0.15.x Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants