-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topics page fixes #8928
Topics page fixes #8928
Conversation
…e subfolders, and toggle behaviors accord with spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some issues here from testing.
When first navigating to the topics page, the folder header is not highlighted, because it requires the query parameter to be set. Overall, I think the interaction on mobile is still confusing - the header links being used as buttons to toggle the side panels feels counterintuitive. As such, the fact that the button for filter is only available in tablet layout but not smaller layouts seems like an issue. |
Also, when first navigating to the search tab, I think we should show the search side panel - otherwise we are requiring users to click the search header and then open the search panel separately, making two clicks to express what they want to do. |
…ow breadcrumbs on smaller screens, and only use tabs on desktop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual testing checks out - just need to prevent the redundant navigation error.
…that caused layout issues
Summary
References
Fixes #8847
Figma spec for medium screens (where the toggling changes were most relevant)
Implementation
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)