Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore duplicate attempts at questions when counting. #8925

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Dec 14, 2021

Summary

  • Duplicate attempts at a question in a quiz can sometimes occur
  • This can then result in a confusing user experience
  • We already account for this in the backend when doing summarization and aggregation, but not in the learner UI
  • This fixes that by doing a count of attempts made unique by item

References

Fixes #8922

Reviewer guidance

This bug is hard to reproduce, so I'd suggest doing an inspection of the code and ensuring this introduces no regressions.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Dec 14, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Dec 14, 2021
Copy link
Contributor

@sairina sairina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - the map seems to have the correct number of questions that were attempted.

@rtibbles rtibbles merged commit d8b548e into learningequality:release-v0.15.x Dec 15, 2021
@rtibbles rtibbles deleted the question_quantum branch December 15, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kolibri Android App - Incorrect quiz completion messages
2 participants