-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make display of attempts parallel between mobile and non-mobile display #8890
Make display of attempts parallel between mobile and non-mobile display #8890
Conversation
Reuse component for KSelect and list display.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me but I ran into a couple spots with some UI weirdness:
- The coach content icon items at ~tablet width have a different width than the rest:
wonky-question-names.mp4
- (I think this is unrelated to your work so not a blocker) "In progress". The icon centers as if there would be a "N minute ago" string under the label like when it is Complete making it off center in this case:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't do the super deep dive, but interacting with the lessons/quizzes and syncing seem to be working without issues.
I'll fix up the issues that @nucleogenesis identified here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coach icon styling weirdness addressed
Summary
<span>
in mobile and<p>
in non-mobile view to use space more efficiently.References
Fixes #8888
Reviewer guidance
Any UI weirdness as a result?
Non-mobile:
Mobile:
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)