Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign headers properly to prevent 500 when database is locked #8886

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Dec 9, 2021

Summary

  • To preempt issues from syncing happening while learners are engaging with content, a middleware was implemented to prompt retries when a database locked error was encountered during progress tracking.
  • Unfortunately, @rtibbles failed to set the headers properly, and tried to pass them as a kwarg to the Django response object, rather than setting them via attribute assignment after instantiation.
  • This resolves that and assigns headers to response object properly to prevent an exception during exception handling.

References

Fixes #8866

Reviewer guidance

Run kolibri as a learner only device, engage with content while syncing is happening. See a 503, but that Kolibri eventually does make a successful request.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Dec 9, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Dec 9, 2021
@radinamatic
Copy link
Member

I repeated all the scenarios that used to trigger 500 in the past few days, but had no luck in seeing it again 💯

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, :shipit:! 👍🏽

@rtibbles rtibbles merged commit 6cd5d85 into learningequality:release-v0.15.x Dec 10, 2021
@rtibbles rtibbles deleted the responsibility_comes_to_a_header branch December 10, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors while interacting with resources in a lesson on Learn-only device
3 participants