Perseus in Coach full width - some coach alignment fixes #8884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When not in interactive mode, the Perseus renderer was unnecessarily showing the hints KFixedGridItem, causing the actual quiz content to be half-width. This hides it with
v-show
so that the content renders properly and the grid spans are adjusted accordingly.(っ◔◡◔)っ ♥ Bonus fixes ♥
width: auto
style took care of that business./deep/
CSS and a TODO in there. HeaderWithOptions needs refactor and I can do it but wanted to get the fix in for the deadline. I can do a more robust fix next week or over the Holidays depending on priorities.References
Fixes #8834
Reviewer guidance
Go look at Quiz reports and make sure questions are full width. Then go make a quiz and verify the same.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)