Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perseus in Coach full width - some coach alignment fixes #8884

Conversation

nucleogenesis
Copy link
Member

@nucleogenesis nucleogenesis commented Dec 9, 2021

Summary

When not in interactive mode, the Perseus renderer was unnecessarily showing the hints KFixedGridItem, causing the actual quiz content to be half-width. This hides it with v-show so that the content renders properly and the grid spans are adjusted accordingly.

(っ◔◡◔)っ ♥ Bonus fixes ♥

  1. Coach content icon was defaulting too 100% width making it drop to a newline - a width: auto style took care of that business.
Before After
image image
  1. (hacky) The backlink was hugging the top on a couple reports and misaligned with the Preview button so I put some /deep/ CSS and a TODO in there. HeaderWithOptions needs refactor and I can do it but wanted to get the fix in for the deadline. I can do a more robust fix next week or over the Holidays depending on priorities.
Before After
image !image

References

Fixes #8834

Reviewer guidance

Go look at Quiz reports and make sure questions are full width. Then go make a quiz and verify the same.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

I checked the others and they were spaced properly - this was just hugging the top
now exercises content shows full width in reports and exam creation
@nucleogenesis nucleogenesis added the TODO: needs review Waiting for review label Dec 9, 2021
@nucleogenesis nucleogenesis added this to the 0.15.0 milestone Dec 9, 2021
@rtibbles
Copy link
Member

(hacky) The backlink was hugging the top on a couple reports and misaligned with the Preview button so I put some /deep/ CSS and a TODO in there. HeaderWithOptions needs refactor and I can do it but wanted to get the fix in for the deadline. I can do a more robust fix next week or over the Holidays depending on priorities.

Can probably leave this, as it should already be cleaned up on develop.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@radinamatic
Copy link
Member

coach resource icon back link
coach-resource-icon

Looks ✔️ in full width, but was it supposed to disappear on smaller sized screens?
back-link

✔️ (we can add some top padding later for narrower screens)

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that what I commented on predates this PR, so we are good to go!

@rtibbles rtibbles merged commit 3e92b9f into learningequality:release-v0.15.x Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiz report content renderer is cut off on the right hand side
3 participants