Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset searchbox input value when search term is cleared #8876

Merged

Conversation

jredrejo
Copy link
Member

@jredrejo jredrejo commented Dec 8, 2021

Summary

When search terms are cleared in the filters, the search input box must be cleared

References

Closes: #8840

Reviewer guidance

  1. Type some search term in the Keywords input box in the Learn-Library tab
  2. Click on the "Clear all" link on the right or on the chip containing the written term
  3. The Keywords input box should be cleared

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added the TODO: needs review Waiting for review label Dec 8, 2021
@jredrejo jredrejo added this to the 0.15.0 milestone Dec 8, 2021
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks right, manual testing checks out.

@rtibbles rtibbles merged commit a56ff92 into learningequality:release-v0.15.x Dec 9, 2021
@jredrejo jredrejo deleted the reset_searchbox branch December 9, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar field on the left should be cleared when "Clear all" is clicked above search results
2 participants