Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include backRoute & context in content link on BrowseResourceMetadata #8863

Conversation

nucleogenesis
Copy link
Member

@nucleogenesis nucleogenesis commented Dec 8, 2021

Summary

Two bugs fixed.

  1. When accessing Bookmarked content from Bookmark's page's side panel the route of the content's back arrow would be the Learn Home page.
  2. Also if a user would have search context and access the content via the side panel, then they'd have to click the back arrow twice and get sent to Learn Home

This change ensures correct context in both cases.

References

Fixes #8830

Reviewer guidance

First - confirm the two bugs above on release-0.15

This is only when clicking view resource in the side panel when browsing content.

Try it in Bookmarks

Try it in the Library Page - with and without search criteria in place. It should always go back to the state you were in when you left.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@nucleogenesis nucleogenesis added the TODO: needs review Waiting for review label Dec 8, 2021
@nucleogenesis nucleogenesis added this to the 0.15.0 milestone Dec 8, 2021
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense - bookmark backlinks work!

with the change to ensure context is kept across navigation, BrowseResourceMetadata calls upon $route - so this makes sure it's present properly
@nucleogenesis nucleogenesis merged commit b585310 into learningequality:release-v0.15.x Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back button does not have correct context when content is accessed from bookmark side panel
2 participants