Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate BaseLogFilter for collection based filtering of logs. #8814

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Dec 7, 2021

Summary

  • Reinstates erroneously deleted BaseLogFilter
  • Adds it to MasteryLog and AttemptLog in case any coach reports are filtering by those (the difficult questions interface in Coach reports filters AttemptLog by classroom and group)

References

Follow up from #8525

Reviewer guidance

This should be harmless and reinstate the required functionality using a slightly more performant UUIDFilter than ModelChoice (which performs a lookup).


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Dec 7, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Dec 7, 2021
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible

@rtibbles rtibbles merged commit 673af18 into learningequality:release-v0.15.x Dec 7, 2021
@rtibbles rtibbles deleted the baselogfilter branch December 7, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants