Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to language modal #8775

Merged
merged 4 commits into from
Nov 29, 2021

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Nov 23, 2021

Summary

before after
image image

References

based on #8636 once learningequality/kolibri-design-system#281

Reviewer guidance

ready for final review and merge


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Contributor

@sairina sairina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked to KDS; works as expected with both strings and numbers.

@radinamatic
Copy link
Member

So good not seeing (Moça... anymore! 👏🏽

Windows 7 Ubuntu 16.04
Win7 (start)  Running  - Oracle VM VirtualBox_008 Ubuntu16 04 (start)  Running  - Oracle VM VirtualBox_001

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as promised! 🎉

@indirectlylit indirectlylit marked this pull request as ready for review November 29, 2021 19:12
@indirectlylit indirectlylit marked this pull request as draft November 29, 2021 19:29
@indirectlylit indirectlylit marked this pull request as ready for review November 29, 2021 20:07
@indirectlylit indirectlylit added this to the 0.15.0 milestone Nov 29, 2021
@rtibbles rtibbles merged commit bbc7972 into learningequality:release-v0.15.x Nov 29, 2021
@indirectlylit indirectlylit deleted the modal branch November 29, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants