Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of coach contents fixes #8766

Merged

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Nov 22, 2021

Summary

This PR fixes case typos and also the problem with the info icon overlapping the progress bar that was caused by footerLength not being a number since the typo resulted in having undefined value in its calculation:

Before After
Screenshot from 2021-11-22 17-49-17 Screenshot from 2021-11-22 17-47-21

After applying these fixes, as you can see on the "After" screenshot above, the resource title truncation doesn't work anymore again as expected (should truncate to 5 lines). I don't think that these updates are causing regression but rather reveal some new layout or styling conditions that also played role in #8667 and maybe @indirectlylit reported the issue under different conditions from when I tried to reproduce it. I'm reopening #8667 and will look into it again.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob added this to the 0.15.0 milestone Nov 22, 2021
@MisRob MisRob requested a review from rtibbles November 22, 2021 17:08
@rtibbles rtibbles merged commit a8071dd into learningequality:release-v0.15.x Nov 22, 2021
@MisRob MisRob deleted the num-coach-contents-fixes branch December 1, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants