-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and tests for metadata labels #8765
Fixes and tests for metadata labels #8765
Conversation
Tested in this build and the 500 error is fixed now plus filtering is fully functional. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments, but looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested it as much as I have been able (in sqlite only) and it has worked perfectly.
Also, seeing how pytest kolibri/core/content/test/test_search.py
results in
371 passed in 63.65 seconds
it's quite impressive.
Great work!
Summary
Fixes #8737
Reviewer guidance
Does filtering seem to produce the correct remaining labels?
When testing I changed this line to
if True:
https://github.com/learningequality/kolibri/blob/release-v0.15.x/kolibri/core/content/utils/search.py#L91 to repeatably execute the queries that are being optimized here.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)