Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undocumented metadata key to H5P content data. #8743

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 18, 2021

Summary

  • It appears that content data for H5P requires a metadata key
  • Some content rely on the existence of this key, otherwise they break
  • This rectifies this by setting the metadata key

References

Fixes unfiled issue with Colors of Kindness H5P content.

Reviewer guidance

Test that the H5P content in the channel with the token birid-riziv works.

I looked on the h5p.org homepage at the bootstrapped content data to check I am not missing any other undocumented keys. This is what appeared to be there:

{
    "library": "H5P.InteractiveVideo 1.22",
    "jsonContent": "{\"interactiveVideo\":{\"video\":{\"files\":[{\"path\":\"https:\\/\\/h5p.org\\/sites\\/default\\/files\\/h5p\\/iv.webm\",\"mime\":\"video\\/webm\",\"copyright\":{\"license\":\"CC BY\",\"title\":\"Berry Smoothie\",\"author\":\"Joanna Siemek\",\"source\":\"http:\\/\\/vimeo.com\\/68264542\",\"version\":\"4.0\"}},{\"path\":\"https:\\/\\/h5p.org\\/sites\\/default\\/files\\/h5p\\/iv.mp4\",\"mime\":\"video\\/mp4\",\"copyright\":{\"license\":\"CC BY\",\"title\":\"Berry Smoothie\",\"author\":\"Joanna Siemek\",\"source\":\"http:\\/\\/vimeo.com\\/68264542\",\"version\":\"4.0\"}}],\"startScreenOptions\":{\"title\":\"Interactive Video\",\"hideStartTitle\":false,\"shortStartDescription\":\"Press the buttons that appear during the video!\"},\"textTracks\":{\"videoTrack\":[{\"kind\":\"subtitles\",\"srcLang\":\"en\",\"label\":\"Subtitles\"}]}},\"summary\":{\"task\":{\"library\":\"H5P.Summary 1.10\",\"params\":{\"intro\":\"<p>Choose the correct statement.<\\/p>\\n\",\"summaries\":[{\"summary\":[\"<p>The smoothie ingredients are blueberries, strawberries, oatmeal cookies and milk.<\\/p>\\n\",\"The smoothie ingredients are blackberries, raspberries, oreos and cream.\",\"The smoothie ingredients are blueberries, raspberries, shortbread and yoghurt.\"],\"tip\":\"\",\"subContentId\":\"caa66847-f3ce-4097-a789-d3548aa502af\"},{\"summary\":[\"First add the berries, then add the cookies and finally the milk.\",\"First add the cookies, then add the milk and finally the berries.\",\"First add the milk, then add the berries and finally the cookies.\"],\"tip\":\"\",\"subContentId\":\"f2df4be4-9d02-4e1d-8cdc-8c5ad8d2ecf8\"},{\"summary\":[\"Use a couple of berries to decorate the top of the smoothie glass.\",\"Use cookie crumbles to decorate the top of the smoothie glass.\",\"Use a tiny paper umbrella to decorate the top of the smoothie glass.\"],\"tip\":\"\",\"subContentId\":\"7b79b66a-f1b3-4b60-87bf-c38fb244e46c\"}],\"solvedLabel\":\"Progress:\",\"scoreLabel\":\"Wrong answers:\",\"resultLabel\":\"Your result\",\"overallFeedback\":[{\"from\":0,\"to\":100,\"feedback\":\"You got @score of @total statements (@percent %) correct.\"}],\"labelCorrect\":\"Correct.\",\"labelIncorrect\":\"Incorrect! Please try again.\",\"labelCorrectAnswers\":\"Correct answers.\",\"tipButtonLabel\":\"Show tip\",\"scoreBarLabel\":\"You got :num out of :total points\",\"progressText\":\"Progress :num of :total\",\"alternativeIncorrectLabel\":\"Incorrect\"},\"subContentId\":\"fbca5d23-241d-4dca-9c7d-6700c2d22baa\",\"metadata\":{\"title\":\"Choose the correct statement.\",\"license\":\"U\",\"contentType\":\"Summary\"}},\"displayAt\":3},\"assets\":{\"interactions\":[{\"action\":{\"library\":\"H5P.Text 1.1\",\"params\":{\"text\":\"<p>The ingredients for this delicious smoothie is:<\\/p>\\n\\n<ul>\\n\\t<li>1 cup milk<\\/li>\\n\\t<li>100g blueberries<\\/li>\\n\\t<li>200g strawberries<\\/li>\\n\\t<li>2 tablespoons condensed milk, sweetened<\\/li>\\n\\t<li>4 oatmeal cookies<\\/li>\\n<\\/ul>\\n\"},\"subContentId\":\"daf7ed80-b254-4910-bba1-a7bc6ff20cb9\",\"metadata\":{\"contentType\":\"Text\",\"license\":\"U\",\"title\":\"Untitled Text\"}},\"x\":4.1753653444676,\"y\":7.4211502782931,\"duration\":{\"from\":2,\"to\":5},\"pause\":false,\"label\":\"<p>Ingredients list<\\/p>\\n\",\"width\":21.480434790902,\"height\":9.5673913126406,\"displayType\":\"button\",\"visuals\":{\"backgroundColor\":\"rgb(255, 255, 255)\",\"boxShadow\":true},\"goto\":{\"url\":{\"protocol\":\"http:\\/\\/\"},\"visualize\":false,\"type\":\"\"},\"buttonOnMobile\":true},{\"action\":{\"library\":\"H5P.MultiChoice 1.14\",\"params\":{\"answers\":[{\"correct\":false,\"text\":\"<div>Blueberry<\\/div>\\n\",\"tipsAndFeedback\":{\"tip\":\"\",\"chosenFeedback\":\"\",\"notChosenFeedback\":\"\"}},{\"correct\":true,\"text\":\"<div>Strawberry<\\/div>\\n\",\"tipsAndFeedback\":{\"tip\":\"\",\"chosenFeedback\":\"\",\"notChosenFeedback\":\"\"}}],\"UI\":{\"showSolutionButton\":\"Show solution\",\"tryAgainButton\":\"Try again\",\"checkAnswerButton\":\"Check\",\"tipsLabel\":\"Show tip\",\"scoreBarLabel\":\"You got :num out of :total points\",\"tipAvailable\":\"Tip available\",\"feedbackAvailable\":\"Feedback available\",\"readFeedback\":\"Read feedback\",\"wrongAnswer\":\"Wrong answer\",\"correctAnswer\":\"Correct answer\",\"shouldCheck\":\"Should have been checked\",\"shouldNotCheck\":\"Should not have been checked\",\"noInput\":\"Please answer before viewing the solution\"},\"question\":\"<p>What kind of berry is this?<\\/p>\\n\",\"behaviour\":{\"enableRetry\":true,\"enableSolutionsButton\":true,\"singlePoint\":true,\"randomAnswers\":true,\"showSolutionsRequiresInput\":true,\"type\":\"auto\",\"confirmCheckDialog\":false,\"confirmRetryDialog\":false,\"autoCheck\":false,\"passPercentage\":100,\"showScorePoints\":true,\"enableCheckButton\":true},\"media\":{\"type\":{\"library\":\"H5P.Image 1.1\",\"params\":{\"file\":{\"path\":\"images\\/image-56685f4e54cc3.jpg\",\"mime\":\"image\\/jpeg\",\"width\":200,\"height\":200,\"copyright\":{\"license\":\"U\"}},\"contentName\":\"Image\",\"alt\":\"Image of a red berry covered with yellow seeds\"},\"subContentId\":\"d074c3aa-6b38-4755-978a-3a8392b6cf30\",\"metadata\":{\"title\":\"FraiseFruitPhoto.jpg\",\"authors\":[{\"name\":\"FoeNyx\",\"role\":\"Author\"}],\"source\":\"https:\\/\\/commons.wikimedia.org\\/wiki\\/File:FraiseFruitPhoto.jpg\",\"license\":\"CC BY-SA\",\"licenseVersion\":\"4.0\",\"contentType\":\"Image\"}},\"disableImageZooming\":false},\"confirmCheck\":{\"header\":\"Finish ?\",\"body\":\"Are you sure you wish to finish ?\",\"cancelLabel\":\"Cancel\",\"confirmLabel\":\"Finish\"},\"confirmRetry\":{\"header\":\"Retry ?\",\"body\":\"Are you sure you wish to retry ?\",\"cancelLabel\":\"Cancel\",\"confirmLabel\":\"Confirm\"},\"overallFeedback\":[{\"from\":0,\"to\":0,\"feedback\":\"Wrong!\"},{\"from\":1,\"to\":99,\"feedback\":\"Almost!\"},{\"from\":100,\"to\":100,\"feedback\":\"Correct!\"}]},\"subContentId\":\"d06868ac-688b-4a31-8fc4-9f756f7c545d\",\"metadata\":{\"title\":\"What kind of berry is this?\",\"license\":\"U\",\"contentType\":\"Multiple Choice\"}},\"x\":56.367432150313,\"y\":33.395176252319,\"duration\":{\"from\":10,\"to\":13},\"pause\":false,\"label\":\"<p>Multiple choice&nbsp;quiz<\\/p>\\n\",\"adaptivity\":{\"correct\":{\"allowOptOut\":false,\"message\":\"\"},\"wrong\":{\"allowOptOut\":false,\"message\":\"\"},\"requireCompletion\":false},\"displayType\":\"button\",\"buttonOnMobile\":true},{\"action\":{\"library\":\"H5P.Blanks 1.12\",\"params\":{\"questions\":[\"<p>Strawberries and *blue*berries are mixed with *milk*&nbsp;and oatmeal *cookies*&nbsp;to make this delicious&nbsp;smoothie.&nbsp;<\\/p>\\n\"],\"showSolutions\":\"Show solutions\",\"tryAgain\":\"Try again\",\"text\":\"<p>Fill in the correct ingredients<\\/p>\\n\",\"checkAnswer\":\"Check\",\"notFilledOut\":\"Please fill in all blanks\",\"behaviour\":{\"enableSolutionsButton\":true,\"autoCheck\":false,\"caseSensitive\":true,\"showSolutionsRequiresInput\":true,\"separateLines\":false,\"enableRetry\":true,\"confirmCheckDialog\":false,\"confirmRetryDialog\":false,\"acceptSpellingErrors\":false,\"enableCheckButton\":true},\"answerIsCorrect\":\"&#039;:ans&#039; is correct\",\"answerIsWrong\":\"&#039;:ans&#039; is wrong\",\"answeredCorrectly\":\"Answered correctly\",\"answeredIncorrectly\":\"Answered incorrectly\",\"solutionLabel\":\"Correct answer:\",\"inputLabel\":\"Blank input @num of @total\",\"inputHasTipLabel\":\"Tip available\",\"tipLabel\":\"Tip\",\"confirmCheck\":{\"header\":\"Finish ?\",\"body\":\"Are you sure you wish to finish ?\",\"cancelLabel\":\"Cancel\",\"confirmLabel\":\"Finish\"},\"confirmRetry\":{\"header\":\"Retry ?\",\"body\":\"Are you sure you wish to retry ?\",\"cancelLabel\":\"Cancel\",\"confirmLabel\":\"Confirm\"},\"overallFeedback\":[{\"from\":0,\"to\":100,\"feedback\":\"You got @score of @total blanks correct.\"}],\"scoreBarLabel\":\"You got :num out of :total points\",\"media\":{\"disableImageZooming\":false}},\"subContentId\":\"6ee46b4e-e3ad-4f3b-8d79-a9832b543dae\",\"metadata\":{\"title\":\"Fill in the correct ingredients\",\"license\":\"U\",\"contentType\":\"Fill in the Blanks\"}},\"x\":42.797494780793,\"y\":68.645640074212,\"duration\":{\"from\":30,\"to\":40},\"pause\":false,\"label\":\"<p>Fill in the blanks<\\/p>\\n\",\"adaptivity\":{\"correct\":{\"allowOptOut\":false,\"message\":\"\"},\"wrong\":{\"allowOptOut\":false,\"message\":\"\"},\"requireCompletion\":false},\"displayType\":\"button\",\"buttonOnMobile\":true},{\"action\":{\"library\":\"H5P.DragQuestion 1.13\",\"params\":{\"scoreShow\":\"Show score\",\"tryAgain\":\"Try again\",\"question\":{\"settings\":{\"size\":{\"width\":620,\"height\":310}},\"task\":{\"elements\":[{\"type\":{\"library\":\"H5P.Image 1.1\",\"params\":{\"contentName\":\"Image\",\"file\":{\"path\":\"images\\/file-52fc90e466b65.png\",\"mime\":\"image\\/png\",\"width\":623,\"height\":478},\"alt\":\"Image of a smoothie\",\"title\":\"Smoothie\"},\"subContentId\":\"60ae3445-3003-4de5-9b13-5b99dab7669b\",\"metadata\":{\"license\":\"U\"}},\"x\":3.2258064516129,\"y\":16.129032258065,\"width\":16.5,\"height\":12.5,\"dropZones\":[],\"backgroundOpacity\":100,\"multiple\":false},{\"type\":{\"library\":\"H5P.Image 1.1\",\"params\":{\"contentName\":\"Image\",\"file\":{\"path\":\"images\\/file-52fc91edaed67.jpg\",\"mime\":\"image\\/jpeg\",\"width\":200,\"height\":200},\"alt\":\"Image of a dark purple berry with a smooth skin\"},\"subContentId\":\"c573f800-cb40-4b96-91de-191c31bb112a\",\"metadata\":{\"license\":\"U\"}},\"x\":79.032258064516,\"y\":16.129032258065,\"width\":5,\"height\":5,\"dropZones\":[\"0\"],\"backgroundOpacity\":100,\"multiple\":false},{\"type\":{\"library\":\"H5P.Image 1.1\",\"params\":{\"contentName\":\"Image\",\"file\":{\"path\":\"images\\/file-52fc92404edbd.jpg\",\"mime\":\"image\\/jpeg\",\"width\":200,\"height\":200},\"alt\":\"Image of a red berry covered with yellow seeds\"},\"subContentId\":\"67f7f627-65f3-4d6e-84ad-7142b2f981a4\",\"metadata\":{\"license\":\"U\"}},\"x\":59.677419354839,\"y\":58.064516129032,\"width\":5,\"height\":5,\"dropZones\":[\"0\"],\"backgroundOpacity\":100,\"multiple\":false},{\"type\":{\"library\":\"H5P.Image 1.1\",\"params\":{\"contentName\":\"Image\",\"file\":{\"path\":\"images\\/file-52fc92846b970.jpg\",\"mime\":\"image\\/jpeg\",\"width\":200,\"height\":200},\"alt\":\"Image of a dark purple clustered berry\"},\"subContentId\":\"755c763e-492d-4d23-b20d-9eed8d347129\",\"metadata\":{\"license\":\"U\"}},\"x\":59.677419354839,\"y\":16.129032258065,\"width\":5,\"height\":5,\"dropZones\":[\"0\"],\"backgroundOpacity\":100,\"multiple\":false},{\"type\":{\"library\":\"H5P.Image 1.1\",\"params\":{\"contentName\":\"Image\",\"file\":{\"path\":\"images\\/file-52fc932fa18da.jpg\",\"mime\":\"image\\/jpeg\",\"width\":200,\"height\":200},\"alt\":\"Image of a red clustered berry\"},\"subContentId\":\"c51ddd4f-5711-4b8d-bb62-7c26a6ff463f\",\"metadata\":{\"license\":\"U\"}},\"x\":79.032258064516,\"y\":58.064516129032,\"width\":5,\"height\":5,\"dropZones\":[\"0\"],\"backgroundOpacity\":100,\"multiple\":false},{\"type\":{\"library\":\"H5P.AdvancedText 1.1\",\"params\":{\"text\":\"<p>Drag &amp; drop the berries used in this recipe&nbsp;on the picture!<\\/p>\\n\"},\"subContentId\":\"b52ef629-0f11-41aa-bd2a-c00ae7f6701d\"},\"x\":1.6129032258065,\"y\":3.2258064516129,\"width\":30.5,\"height\":2,\"dropZones\":[],\"backgroundOpacity\":100,\"multiple\":false}],\"dropZones\":[{\"x\":3.2258064516129,\"y\":16.129032258065,\"width\":16.5,\"height\":12.5,\"correctElements\":[\"2\",\"1\"],\"showLabel\":false,\"backgroundOpacity\":0,\"label\":\"Smoothie\",\"tipsAndFeedback\":{\"tip\":\"\",\"feedbackOnCorrect\":\"\",\"feedbackOnIncorrect\":\"\"},\"single\":false,\"autoAlign\":false}]}},\"behaviour\":{\"enableRetry\":true,\"singlePoint\":true,\"showSolutionsRequiresInput\":true,\"applyPenalties\":true,\"enableScoreExplanation\":true,\"dropZoneHighlighting\":\"dragging\",\"autoAlignSpacing\":2,\"enableFullScreen\":false,\"showScorePoints\":true,\"enableCheckButton\":true,\"showTitle\":true},\"scoreExplanation\":\"Correct answers give +1 point. Incorrect answers give -1 point. The lowest possible score is 0.\",\"localize\":{\"fullscreen\":\"Fullscreen\",\"exitFullscreen\":\"Exit fullscreen\"},\"overallFeedback\":[{\"from\":0,\"to\":100,\"feedback\":\"You got @score of @total points.\"}],\"grabbablePrefix\":\"Grabbable {num} of {total}.\",\"grabbableSuffix\":\"Placed in dropzone {num}.\",\"dropzonePrefix\":\"Dropzone {num} of {total}.\",\"noDropzone\":\"No dropzone.\",\"tipLabel\":\"Show tip.\",\"tipAvailable\":\"Tip available\",\"correctAnswer\":\"Correct answer\",\"wrongAnswer\":\"Wrong answer\",\"feedbackHeader\":\"Feedback\",\"scoreBarLabel\":\"You got :num out of :total points\",\"scoreExplanationButtonLabel\":\"Show score explanation\"},\"subContentId\":\"bd5267da-0da1-4aab-8206-0e205e6f31d1\",\"metadata\":{\"title\":\"Drag and drop\",\"license\":\"U\",\"contentType\":\"Drag and Drop\"}},\"x\":62.630480167015,\"y\":33.395176252319,\"duration\":{\"from\":45,\"to\":52},\"pause\":false,\"label\":\"<p>Drag &amp; drop quiz<\\/p>\\n\",\"adaptivity\":{\"correct\":{\"allowOptOut\":false,\"message\":\"\"},\"wrong\":{\"allowOptOut\":false,\"message\":\"\"},\"requireCompletion\":false},\"displayType\":\"button\",\"buttonOnMobile\":true},{\"action\":{\"library\":\"H5P.Text 1.1\",\"params\":{\"text\":\"<p>Add a few berries on top of the glass and serve immediately!<\\/p>\\n\"},\"subContentId\":\"076d0968-4196-494f-b6e6-763941beb6d3\",\"metadata\":{\"contentType\":\"Text\",\"license\":\"U\",\"title\":\"Untitled Text\"}},\"x\":19.832985386221,\"y\":40.816326530612,\"duration\":{\"from\":57,\"to\":62},\"pause\":false,\"label\":\"Serving tips\",\"displayType\":\"button\",\"visuals\":{\"backgroundColor\":\"rgb(255, 255, 255)\",\"boxShadow\":true},\"goto\":{\"url\":{\"protocol\":\"http:\\/\\/\"},\"visualize\":false,\"type\":\"\"},\"buttonOnMobile\":true},{\"action\":{\"library\":\"H5P.MarkTheWords 1.9\",\"params\":{\"checkAnswerButton\":\"Check\",\"tryAgainButton\":\"Retry\",\"showSolutionButton\":\"Show solution\",\"behaviour\":{\"enableRetry\":false,\"enableSolutionsButton\":false,\"showScorePoints\":true,\"enableCheckButton\":true},\"taskDescription\":\"<p>Highlight the ingredients that have been added so far.<\\/p>\\n\",\"textField\":\"*Strawberries* Cookies *Blueberries* Milk\",\"correctAnswer\":\"Correct!\",\"incorrectAnswer\":\"Incorrect!\",\"missedAnswer\":\"Missed!\",\"displaySolutionDescription\":\"Task is updated to contain the solution.\",\"overallFeedback\":[{\"from\":0,\"to\":100,\"feedback\":\"You got @score of @total blanks correct.\"}],\"scoreBarLabel\":\"You got :num out of :total points\",\"a11yFullTextLabel\":\"Full readable text\",\"a11yClickableTextLabel\":\"Full text where words can be marked\",\"a11ySolutionModeHeader\":\"Solution mode\",\"a11yCheckingHeader\":\"Checking mode\"},\"subContentId\":\"ac89ad57-8a23-402e-86dd-c5f7fcb3f08f\",\"metadata\":{\"title\":\"Highlight the ingredients that have been added so far.\",\"license\":\"U\",\"contentType\":\"Mark the Words\"}},\"x\":10.460251046025,\"y\":20.446096654275,\"width\":30.962343096234,\"height\":13.807531380753,\"duration\":{\"from\":20,\"to\":21},\"pause\":true,\"displayType\":\"poster\",\"adaptivity\":{\"correct\":{\"allowOptOut\":false,\"message\":\"\"},\"wrong\":{\"allowOptOut\":false,\"seekTo\":0,\"message\":\"<p>You need to pay closer attention!<\\/p>\\n\",\"seekLabel\":\"Watch intro again\"},\"requireCompletion\":false},\"label\":\"\",\"buttonOnMobile\":true}],\"bookmarks\":[{\"time\":2.56,\"label\":\"Recipe\"},{\"time\":8.92252,\"label\":\"Preparing\"},{\"time\":32.588481,\"label\":\"Mixing\"},{\"time\":53.53,\"label\":\"Serving\"}],\"endscreens\":[{\"time\":65.30785,\"label\":\"1:05 Submit screen\"}]}},\"override\":{\"showBookmarksmenuOnLoad\":false,\"showRewind10\":false,\"loop\":false,\"preventSkipping\":false,\"deactivateSound\":false,\"autoplay\":false},\"l10n\":{\"interaction\":\"Interaction\",\"play\":\"Play\",\"pause\":\"Pause\",\"mute\":\"Mute\",\"quality\":\"Video Quality\",\"unmute\":\"Unmute\",\"fullscreen\":\"Fullscreen\",\"exitFullscreen\":\"Exit Fullscreen\",\"summary\":\"Summary\",\"bookmarks\":\"Bookmarks\",\"defaultAdaptivitySeekLabel\":\"Continue\",\"continueWithVideo\":\"Continue with video\",\"playbackRate\":\"Playback Rate\",\"rewind10\":\"Rewind 10 Seconds\",\"navDisabled\":\"Navigation is disabled\",\"sndDisabled\":\"Sound is disabled\",\"requiresCompletionWarning\":\"You need to answer all the questions correctly before continuing.\",\"back\":\"Back\",\"captions\":\"Captions\",\"close\":\"Close\",\"hours\":\"Hours\",\"minutes\":\"Minutes\",\"seconds\":\"Seconds\",\"currentTime\":\"Current time:\",\"totalTime\":\"Total time:\",\"singleInteractionAnnouncement\":\"Interaction appeared:\",\"multipleInteractionsAnnouncement\":\"Multiple interactions appeared.\",\"videoPausedAnnouncement\":\"Video is paused\",\"content\":\"Content\",\"endscreen\":\"Submit screen\",\"answered\":\"@answered answered\",\"endcardTitle\":\"@answered Question(s) answered\",\"endcardInformation\":\"You have answered @answered questions, click below to submit your answers.\",\"endcardInformationNoAnswers\":\"You have not answered any questions.\",\"endcardInformationMustHaveAnswer\":\"You have to answer at least one question before you can submit your answers.\",\"endcardSubmitButton\":\"Submit Answers\",\"endcardSubmitMessage\":\"Your answers have been submitted!\",\"endcardTableRowAnswered\":\"Answered questions\",\"endcardTableRowScore\":\"Score\",\"endcardAnsweredScore\":\"answered\",\"endCardTableRowSummaryWithScore\":\"You got @score out of @total points for the @question that appeared after @minutes minutes and @seconds seconds.\",\"endCardTableRowSummaryWithoutScore\":\"You have answered the @question that appeared after @minutes minutes and @seconds seconds.\"}}",
    "fullScreen": "1",
    "exportUrl": "https://h5p.org/sites/default/files/h5p/exports/interactive-video-2-618.h5p",
    "embedCode": "<iframe src=\"https://h5p.org/h5p/embed/617\" width=\":w\" height=\":h\" frameborder=\"0\" allowfullscreen=\"allowfullscreen\" allow=\"geolocation *; microphone *; camera *; midi *; encrypted-media *\" title=\"Interactive Video\"></iframe>",
    "resizeCode": "<script src=\"https://h5p.org/sites/all/modules/h5p/library/js/h5p-resizer.js\" charset=\"UTF-8\"></script>",
    "mainId": "617",
    "url": "https://h5p.org/node/617",
    "contentUserData": [
        {
            "state": "{}"
        }
    ],
    "displayOptions": {
        "frame": true,
        "export": true,
        "embed": true,
        "copyright": true,
        "icon": true,
        "copy": false
    },
    "metadata": {
        "license": "U",
        "licenseExtras": "Created by Joanna Siemek. Licensed under Creative Commons&nbsp;Attribution 3.0 Unported (CC BY 3.0). Link:&nbsp;https://vimeo.com/68264542\n",
        "defaultLanguage": "en",
        "title": "Interactive Video"
    },
    "styles": [
        "https://h5p.org/sites/default/files/css/css_QGTcpFIqPBku0q__lZHkh1UdzfO9d10lg-4H5etUOWE.css"
    ],
    "scripts": [
        "https://h5p.org/sites/default/files/js/js_Oq1NnchnH-d5oe5oLj0p7iX0jOwvYG7ESQ36JLX4gWA.js"
    ]
}

Screenshot from 2021-11-18 15-15-34


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from radinamatic November 18, 2021 23:16
@rtibbles rtibbles added the TODO: needs review Waiting for review label Nov 18, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Nov 18, 2021
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code read through looks straightforward enough, but will wait for Radina's manual QA to double check :)

@radinamatic
Copy link
Member

Things seem to be working on both Windows 7 & Windows 10, plus Ubuntu 16.04! 💯

Windows 7 Windows 10 Ubuntu 16.4
Win7 (start)  Running  - Oracle VM VirtualBox_026 Win10 (start)  Running  - Oracle VM VirtualBox_046 Ubuntu16 04 (start)  Running  - Oracle VM VirtualBox_007

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 💯

@rtibbles rtibbles merged commit 26d058f into learningequality:release-v0.15.x Nov 19, 2021
@rtibbles rtibbles deleted the h5ps_and_h5qs branch November 19, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants