Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Folders tab when no topics available on channel page #8713

Conversation

nucleogenesis
Copy link
Member

Summary

The Folders tab was showing because [] == true so I added some .length checks to the display logic there.

The issue reports that the problem was that the Folders tab had a worthless "View more" link shown, but I think that the pointless empty tab needed hidden as well.

References

Fixes #8701

Reviewer guidance

Do channels like the example one in #8701 have the Folders tab?

Do channels like Kolibri QA Channel (which has folders) show the tab properly?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@nucleogenesis nucleogenesis added the TODO: needs review Waiting for review label Nov 16, 2021
@nucleogenesis nucleogenesis added this to the 0.15.0 milestone Nov 16, 2021
@rtibbles rtibbles merged commit 58634a1 into learningequality:release-v0.15.x Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'View more' link under 'Folders' in channel with no folders
2 participants