Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show user sync tasks in the Channels tasks #8710

Merged

Conversation

jredrejo
Copy link
Member

Summary

In a Learner Only Device, the syncing of users tasks were appearing in the channels importing tasks, showing an ugly TaskPanel.undefined message

This PR filters this kind of tasks to avoid their appearance in this window

image

References

Closes: #8393

Reviewer guidance

After creating a LOD, check that no odd tasks message appear in the Channels tab when the users are synced in the background

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added the TODO: needs review Waiting for review label Nov 16, 2021
@jredrejo jredrejo added this to the 0.15.0 milestone Nov 16, 2021
@jredrejo jredrejo requested a review from radinamatic November 16, 2021 20:10
@rtibbles rtibbles merged commit 2dd138c into learningequality:release-v0.15.x Nov 16, 2021
@jredrejo jredrejo deleted the filter_loud_task branch November 17, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync tasks are affecting channel import UI
2 participants