Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly store answer state after initial attempt for exercises #8647

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 10, 2021

Summary

  • Answer state in the frontend was being erroneously overwritten, meaning the appropriate corrected state was not being shown to the user
  • This fixes that by not storing these fields into the vuex store when the attempt already exists there, if the 'replace' flag is not specified.

References

Fixes #8606

Reviewer guidance

Answer an exercise question incorrectly - now get it right - does it show as 'corrected' (small black dot) rather than 'correct' (big green tick/check mark)?

corrected


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Nov 10, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Nov 10, 2021
@pcenov
Copy link
Member

pcenov commented Nov 10, 2021

Tested and confirmed that the issue is fixed in this build.

@radinamatic
Copy link
Member

corrected_correctly in now correct! 🎉

corrected_correctly

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All correct! 💯

@marcellamaki marcellamaki merged commit 817885e into learningequality:release-v0.15.x Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Never indicate that a response is 'correct' when it is 'corrected'
4 participants