-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly fetch more progress for tree data. #8646
Properly fetch more progress for tree data. #8646
Conversation
Only fetch it when logged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, so going to approve and merge. For manual QA, I don't see any issues but I'd only noticed this bug when running the pex file during the bug bash, not when running the dev server. I can download that later today or tomorrow and confirm the fix is working as expected.
We can give it a go now! 🙂 (cc @pcenov) |
@pcenov - I was looking at this today and so far haven't been able to replicate it, so I want to double check that I'm trying the same scenario. I am on the home page as a logged in user, who is not enrolled in any classes. I am clicking "view more" under the "Continue learning on your own" header. Is this what you were testing? If not, can you let me know what I should try instead? Thank you!! |
@marcellamaki to replicate this one you have to:
|
Thank you @pcenov -- I will try that! And no need to report is separately - I'll take a little time today to investigate and address |
Summary
References
Fixes #8607
Reviewer guidance
Load a topic in a channel with more than 12 descendants
Go to 'view all'
Ensure that it does not briefly suggest that Kolibri is disconnected
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)