Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fetch more progress for tree data. #8646

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 10, 2021

Summary

  • fetchContentNodeTreeProgress was being invoked with inconsistent function signatures
  • Standardize its invocation on an options object
  • Conditionalize fetching based on whether the user is logged in

References

Fixes #8607

Reviewer guidance

Load a topic in a channel with more than 12 descendants
Go to 'view all'
Ensure that it does not briefly suggest that Kolibri is disconnected

showmoreprogress


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Only fetch it when logged in.
@rtibbles rtibbles added the TODO: needs review Waiting for review label Nov 10, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Nov 10, 2021
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, so going to approve and merge. For manual QA, I don't see any issues but I'd only noticed this bug when running the pex file during the bug bash, not when running the dev server. I can download that later today or tomorrow and confirm the fix is working as expected.

@radinamatic
Copy link
Member

We can give it a go now! 🙂 (cc @pcenov)

@marcellamaki marcellamaki merged commit df6356d into learningequality:release-v0.15.x Nov 10, 2021
@pcenov
Copy link
Member

pcenov commented Nov 10, 2021

Looks good to me as well - I'm not seeing any suggestions that Kolibri is disconnecting.
At the same time I noticed that when I click the View more option while viewing the page in mobile view there is an error in the console: GET http://127.0.0.1:8080/en/learn/[object%20Object] 404 (Not Found)

2021-11-10_16-42-21

@rtibbles rtibbles deleted the more_progress branch November 10, 2021 16:27
@marcellamaki
Copy link
Member

@pcenov - I was looking at this today and so far haven't been able to replicate it, so I want to double check that I'm trying the same scenario. I am on the home page as a logged in user, who is not enrolled in any classes. I am clicking "view more" under the "Continue learning on your own" header. Is this what you were testing? If not, can you let me know what I should try instead? Thank you!!

@pcenov
Copy link
Member

pcenov commented Nov 11, 2021

@marcellamaki to replicate this one you have to:

  1. Go to the Library page
  2. Filter by some criteria, for example Language: English
  3. Select the View as list option for the search results
  4. Scroll down and click the View more button
    I just mentioned it above as an indirect observation for a possible issue - let me know if I should report it separately.

@marcellamaki
Copy link
Member

marcellamaki commented Nov 11, 2021

Thank you @pcenov -- I will try that! And no need to report is separately - I'll take a little time today to investigate and address

@rtibbles rtibbles mentioned this pull request Nov 11, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading ContentNodeProgress data when loading more topics causes errors
4 participants