Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SoUD hash to facility stats #8644

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Add SoUD hash to facility stats #8644

merged 1 commit into from
Nov 10, 2021

Conversation

bjester
Copy link
Member

@bjester bjester commented Nov 9, 2021

Summary

  • Adds SoUD hash parameter sh to facility statistics sent to telemetry and received by this work

References

Resolves #8568

Reviewer guidance

Are tests adequate?
Do tests pass?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester added TODO: needs review Waiting for review changelog Important user-facing changes python labels Nov 9, 2021
@bjester bjester added this to the 0.15.0 milestone Nov 9, 2021
@bjester bjester requested review from rtibbles and jamalex November 9, 2021 23:42
jamalex
jamalex approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@jamalex jamalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding thorough testing and cleaning things up! ✋

kolibri/core/analytics/test/test_utils.py
@@ -273,6 +297,7 @@ def test_extract_facility_statistics(self):
}

assert actual == expected
self.assertNotIn("sh", actual)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's implied by the equivalence assertion, but good to have it be explicit, yeah!

@bjester bjester merged commit cc3e672 into learningequality:release-v0.15.x Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamalex jamalex jamalex approved these changes

@rtibbles rtibbles Awaiting requested review from rtibbles

Assignees
No one assigned
Labels
changelog Important user-facing changes TODO: needs review Waiting for review
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

Send soud_hash value to telemetry
2 participants
@bjester @jamalex