Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design alignment updates #8598

Conversation

marcellamaki
Copy link
Member

Summary

Handles various pieces of design speccing alignment feedback, including some tasks in #8563 and other PR feedback and issues.

Included Items

Topics Page

  • Add "active" styles for folders and search tab
  • Active side panel buttons styles

Screen Shot 2021-11-04 at 7 49 25 PM

Library page

  • Fix mobile card view that sometimes shows up as a grid with toggle, when should just be single card
  • no toggle on 0 results (in case there are ever a 0 results page)

Screen Shot 2021-11-04 at 7 47 29 PM

  • Active side panel buttons styles
view 1 view 2
Screen Shot 2021-11-04 at 7 31 20 PM Screen Shot 2021-11-04 at 7 31 08 PM

Bookmarks page

  • Card: Add text truncation to manage long description overflow and spacing issues

Reference

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this - but I think we can do some more cleanup here.

kolibri/plugins/learn/assets/src/views/LibraryPage.vue Outdated Show resolved Hide resolved
kolibri/plugins/learn/assets/src/views/LibraryPage.vue Outdated Show resolved Hide resolved
:disabled="availableRootCategories && !availableRootCategories[val]"
:disabled="availableRootCategories &&
!availableRootCategories[val] &&
!activeKeys.filter(k => k.includes(val)).length"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should do this as a computed prop - and there's probably a better way to do the existence check.

@rtibbles rtibbles merged commit d06c00b into learningequality:release-v0.15.x Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants