Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting right device permissions in the setup wizard #8595

Conversation

jredrejo
Copy link
Member

@jredrejo jredrejo commented Nov 4, 2021

Summary

When provisioning a new device, if learner_can_login_with_no_password is set as true, the wizard must unset learner_can_edit_password (if not, it's defaulted to True in the Django model)

References

Closes: #8250

Reviewer guidance

Run the wizard following the steps described in #8250 . The process should finish correctly, without server errors.

Testing checklist

  • Contributor has fully tested the PR manually
  • [] If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added the TODO: needs review Waiting for review label Nov 4, 2021
@jredrejo jredrejo added this to the 0.15.0 milestone Nov 4, 2021
@jredrejo jredrejo requested a review from rtibbles November 4, 2021 19:08
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good - @pcenov can you confirm the fix here?

@rtibbles rtibbles merged commit d815757 into learningequality:release-v0.15.x Nov 5, 2021
@pcenov
Copy link
Member

pcenov commented Nov 5, 2021

@rtibbles and @jredrejo - the fix is confirmed, awesome! :)

@jredrejo jredrejo deleted the learner_can_edit_password_false branch November 5, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup wizard - Error if Enable passwords on learner accounts is set to 'No'
3 participants