-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update channel topic browsing #8535
Closed
marcellamaki
wants to merge
44
commits into
learningequality:release-v0.15.x
from
marcellamaki:update-channel-topic-browsing
Closed
Update channel topic browsing #8535
marcellamaki
wants to merge
44
commits into
learningequality:release-v0.15.x
from
marcellamaki:update-channel-topic-browsing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cards, rather than modify existing components, to prevent regressions
…t content bookmark status in LearningActivityBar
…instead of ContentCardGroupGrid
…cards, rather than modify existing components, to prevent regressions
…ch cards are used and grid at different sizes
…rking. No translations/string mapping - using ids
…ity of use and better card alignment
Add channel title and thumbnail data to normalizeContentNode.
marcellamaki
force-pushed
the
update-channel-topic-browsing
branch
from
October 25, 2021 23:41
f5aca4e
to
6014b0d
Compare
marcellamaki
changed the title
DRAFT Update channel topic browsing
Update channel topic browsing
Oct 26, 2021
marcellamaki
force-pushed
the
update-channel-topic-browsing
branch
from
October 26, 2021 13:27
6014b0d
to
83bb347
Compare
Superseded by #8548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the channel topic page to use:
References
Addresses #8306
Figma
…
Reviewer guidance
Much of the search/filter functionality is copied from
LibraryPage
and while it deserves some testing to make sure everything is still working, it is more a question if there is some case that was unintentionally broken, rather than a full review of all of the code - since it continues to just build on Richard's original PR.On the front end - there are some pieces that feel a little...janky, for lack of a better word, so if anyone has suggestions of how I can make things feel a little smoother, would be happy to hear them. Thinking particularly of the embedded side bar and the computed prop used for "stickiness"
@nucleogenesis would appreciate your eyes on the updates to the fullscreen side panel, and make sure that it still works with your plan and uses, and that I haven't caused any regressions there
What is included in this PR/What to test for - Manual/Design QA:
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)