Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use calculate_max_sqlite_variables to avoid errors in merge_users #8473

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

jamalex
Copy link
Member

@jamalex jamalex commented Sep 29, 2021

Summary

We were seeing sqlite3.OperationalError: too many SQL variables errors on a tablet running the merge_users command, due to large numbers of bulk-created log records. This PR uses the maximum SQLite variable calculation from Morango to scale back the batch size as needed to avoid the error.

Uncertainty: do we want to cap the max at something lower than what the SQLite variable max might be? And do we want something larger by default for non-SQLite databases?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jamalex jamalex added this to the 0.15.0 milestone Sep 29, 2021
calculate_max_sqlite_variables() // len(LogModel._meta.fields)
if vendor == "sqlite"
else 750
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I used an inline conditional because the linting was complaining about function complexity and I didn't have it in me to try to start refactoring other stuff :) )

Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtibbles rtibbles merged commit 7bf9ada into learningequality:release-v0.15.x Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants