Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly test that we do not prematurely initialize our OPTIONS #8415

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Sep 9, 2021

Summary

  • Currently our test for no premature initialization of OPTIONS is undercut by pytest-django loading Django settings, which initialize Kolibri's OPTIONS object
  • Get around this by making tests in our root test/ folder run without the pytest-django plugin
  • Then move the cli import test into this folder

References

Follow up to #8372 to try to prevent us getting into that state again!

Reviewer guidance

Does the separation of tests make sense?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Move cli import tests to test/
@rtibbles rtibbles added the TODO: needs review Waiting for review label Sep 9, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Sep 9, 2021
@rtibbles rtibbles requested a review from bjester September 9, 2021 22:52
@@ -27,7 +27,8 @@ deps =
commands =
sh -c 'kolibri manage makemigrations --check'
# Run the actual tests
python -O -m pytest {posargs:--cov=kolibri --cov-report= --cov-append --color=no}
python -O -m pytest {posargs:--cov=kolibri --cov-report= --cov-append --color=no} kolibri
python -O -m pytest {posargs:--cov=kolibri --cov-report= --cov-append --color=no} -p no:django test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial concern was that the second execution would overwrite the code coverage, but seems that's what --cov-append addresses.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're also not actually reporting our code coverage - it gets messed up because of our conditional test runs.

@rtibbles rtibbles merged commit 592b165 into learningequality:develop Sep 15, 2021
@rtibbles rtibbles deleted the no_conf_till_setup branch September 15, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants