Remove use of python ua-parser from the backend. #8401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ua-parser
module is exhaustive, and as a result requires at least a thousand regexes.ua-parser-js
library (which is far more performant than other user agent libraries), and which we were already partially using in vendored formReferences
Removes major initialization bottleneck, reducing startup time from ~5s to < 0.1s.
Follow up from #7658
Reviewer guidance
Does login and subsequent pings to the session endpoint work?
Does appropriate data get recorded in the UserSessionLog?
Is startup performance on Android improved?
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)