-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invocations of read_channel_metadata_from_db_file to expect a dict #8369
Conversation
… return rather than object.
@radinamatic I confirm that export and import to external drive is now working in both Linux and Windows. |
Thank you, @pcenov! 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA team says
"id": channel["id"], | ||
"name": channel["name"], | ||
"description": channel["description"], | ||
"tagline": channel.get("tagline", ""), | ||
"thumbnail": channel["thumbnail"], | ||
"version": channel["version"], | ||
"root": channel["root_id"], | ||
"author": channel["author"], | ||
"last_updated": channel.get("last_updated"), | ||
"lang_code": channel.get("lang_code"), | ||
"lang_name": channel.get("lang_name"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the inconsistency in getter style because some of these are supposed to throw value errors and others are supposed to return None
if the items doesn't exist?
(Mainly just curious if this is part of an implicit required/optional API of some kind)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it was 'like that when I got here' at this point, I am inferring - but I think these use of get
versus direct key access is a result of newer fields being added that might be undefined in historic channel DB schema.
Summary
References
Fixes #8251
Reviewer guidance
Can you now export to an external drive?
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)