Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL prefixing for static urls #8366

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

rtibbles
Copy link
Member

Summary

Gets rid of hardcoded URL for finding mathjax and uses static URL function.

References

Fixes #8358

Reviewer guidance

Run Kolibri with this env var set: KOLIBRI_URL_PATH_PREFIX="/kolibri"

Without this PR, it will 404 trying to load the Mathjax static file when rendering an exercise. With this PR it loads correctly.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Aug 30, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Aug 30, 2021
@rtibbles rtibbles changed the base branch from release-v0.15.x to develop August 30, 2021 21:51
@pcenov
Copy link
Member

pcenov commented Aug 31, 2021

After installing the Windows build and running Kolibri with an env var set as KOLIBRI_URL_PATH_PREFIX="/kolibri" I don't see any issues in rendering the Spanish KA exercises. Let me know if there is a specific exercise which was failing so that I can confirm for it specifically.

@radinamatic
Copy link
Member

Was this a Windows only issue? No 404s on MathJax files on Ubuntu with or without the env var set... 😀

1 2
Ubuntu18 04 (start)  Running  - Oracle VM VirtualBox_001 Ubuntu18 04 (start)  Running  - Oracle VM VirtualBox_002

@rtibbles
Copy link
Member Author

I was definitely able to replicate on Ubuntu without this fix, and then see it resolved with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanish KA exercise does not render
3 participants