Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap order of build commands to allow passing arguments to build proc… #8322

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Swap order of build commands to allow passing arguments to build proc… #8322

merged 1 commit into from
Aug 18, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 18, 2021 •
edited
Loading

Summary

  • Swaps order of build commands

References

Fixes #6699

Reviewer guidance

Do assets still build?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Aug 18, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Aug 18, 2021
@rtibbles rtibbles requested a review from marcellamaki August 18, 2021 03:18
marcellamaki
marcellamaki approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and build works!

@marcellamaki marcellamaki merged commit 02a9514 into learningequality:develop Aug 18, 2021
@rtibbles rtibbles deleted the single_core branch August 18, 2021 14:05
@rtibbles rtibbles mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

Assignees
No one assigned
Labels
TODO: needs review Waiting for review
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @marcellamaki