Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defensive guard for ref. #8317

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Add defensive guard for ref. #8317

merged 1 commit into from
Aug 18, 2021

Conversation

rtibbles
Copy link
Member

Summary

  • Adds a defensive guard for a ref not being defined yet.

References

Fixes #5372


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Aug 17, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Aug 17, 2021
@rtibbles rtibbles linked an issue Aug 18, 2021 that may be closed by this pull request
@marcellamaki marcellamaki merged commit 416fb7b into develop Aug 18, 2021
@rtibbles rtibbles deleted the sidenav-ref-guard branch August 18, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: this.$refs.sideNav is undefined
2 participants