-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a resource completion modal #8267
Add a resource completion modal #8267
Conversation
There is a new need to use it the `learn` plugin.
Close button should be the last one.
and remove `MasteredSnackbars` components as it's not used anymore from anywhere.
bbd109f
to
0c3125b
Compare
Looking good to me @MisRob! 💯 Tested as signed in and anonymous user, in RTL, and on small resolutions. Keyboard navigation works well, focus is trapped inside modal and with logical order of interactive elements. 🙂
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a first read and so far it looks great, but I got to this later in the day than I was expecting and want to give it another look in the morning when my brain is fresher to be sure I'm not missing anything. But nice work @MisRob - appreciate (as always) your super clean code and all of the comments 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @MisRob! ✅
Summary
Removes mastery snackbars in favor of new responsive completion modal.
Note that "Next resources" section at the bottom of a resource page hasn't been removed intentionally as we don't have UI for navigating to the next resource after closing the completion modal yet.
References
Reviewer guidance
(A) Channel resource page
(B) Channel resource page for anonymous user
Make sure you're logged out and follow (A) steps. In addition to that, check that the warning message is displayed instead of the point obtained on the modal after completing a resource.
(C) Class resource page
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)