-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix soud intervals #8262
Merged
rtibbles
merged 8 commits into
learningequality:release-v0.15.x
from
jredrejo:fix_soud_intervals
Aug 13, 2021
Merged
Fix soud intervals #8262
rtibbles
merged 8 commits into
learningequality:release-v0.15.x
from
jredrejo:fix_soud_intervals
Aug 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtibbles
reviewed
Aug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding a sync_interval
argument to the sync command to both flag that we need to schedule a new sync and also how long we should wait.
rtibbles
reviewed
Aug 11, 2021
rtibbles
reviewed
Aug 11, 2021
rtibbles
reviewed
Aug 11, 2021
rtibbles
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Closes: #8236
Fixes "Possible that sync jobs can get duplicated for the same server when the server is restarted" from https://www.notion.so/learningequality/Single-User-Syncing-Hack-Session-60-mins-bfb609b7d7de47b1af1e73b6446e3cbd
Reviewer guidance
Restart several times the server or the synced server and check everything is working fine
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)