Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test modifications to verify exam related logs are synced #8261

Merged

Conversation

bjester
Copy link
Member

@bjester bjester commented Aug 3, 2021

Summary

  • Updates single-user ecosystem test to include exam related logs to verify those are synced to the server

References

Notion link

Reviewer guidance

INTEGRATION_TEST=1 pytest -s -x -k test_single_user_assignment_sync kolibri/core/auth/test/test_morango_integration.py

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester added this to the 0.15.0 milestone Aug 3, 2021
@bjester bjester requested a review from jamalex August 3, 2021 22:54
@bjester bjester added the TODO: needs review Waiting for review label Aug 3, 2021
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests looks like the correct test, and it does indeed fail when run locally. Not sure whether we want to merge yet or not, but maybe we should have a scheduled integration test run?

@bjester bjester merged commit 2d0cf3d into learningequality:release-v0.15.x Aug 31, 2021
@bjester bjester deleted the exam-log-sync-test branch August 31, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants