Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include --CONTEXT-- placeholder in all extracted messages #8258

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 3, 2021

Summary

  • Restores the addition of the --CONTEXT-- placeholder in all extracted strings.

References

Follow up from #8224

Reviewer guidance

Do strings with no context still have the --CONTEXT-- placeholder in them when uploaded to crowdin?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the 0.15.0 milestone Aug 3, 2021
@radinamatic
Copy link
Member

radinamatic commented Aug 3, 2021

--CONTEXT-- is back! 🎉

I checked out the PR branch and uploaded the strings to the test radina-context branch/folder on Crowdin:

radina-context release-v0.15.x
kolibri plugins learn-messages csv - Kolibri - Learning Platform - Crowdin translation — Mozilla Firefox_002 kolibri plugins learn-messages csv - Kolibri - Learning Platform - Crowdin translation — Mozilla Firefox_003

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for bringing this back!

@rtibbles rtibbles merged commit 6356d4b into learningequality:release-v0.15.x Aug 4, 2021
@rtibbles rtibbles deleted the context_matters branch August 4, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants