Make sure adhoc groups have a name. #8242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes issue with adhoc groups not getting deserialized during syncs
Reviewer guidance
I couldn't do a simple change to the default behaviour for adhocgroups to allow deserialization of empty names.
I think it might be possible by overriding the full clean method of the AdHocGroup model, but it seemed good to get this in for now, and assess if follow up was needed.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)