Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several new features for the 0.15 release #8233

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

pcenov
Copy link
Member

@pcenov pcenov commented Jul 28, 2021

No description provided.

@rtibbles rtibbles changed the base branch from develop to release-v0.15.x July 28, 2021 14:09
@@ -0,0 +1,152 @@
Feature: Import individual users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just change the filename to reflect that it's a part of the setup wizard procedure:
super-admin-setup-wizard-import-individual-users.feature

Then I see *Device name*
And I see <My device's name>
When I click *Continue*
Then I see *Initialize device*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We changed the wording here, check the latest on the Figma prototype:
https://www.figma.com/file/w3raYcGRUhhaVm1Of8Dcvo?node-id=229:63#94924868

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've changed 'Initialize device' to 'Select a facility setup for this device' here and in subsequent lines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, push both changes in a new commit and I'll approve! 👍🏽

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First 0.15 season pickles, 😋!

@rtibbles rtibbles merged commit f32e5a8 into learningequality:release-v0.15.x Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants