-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel based quizzes #8212
Channel based quizzes #8212
Conversation
…annel_based_quizzes
…ns, move params into promise
8e88e5c
to
4445211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick skim didn't flag anything except the unresolved merge conflict.
Will do some manual testing.
kolibri/plugins/coach/assets/src/modules/examCreation/actions.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Tibbles <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working perfectly to spec.
One thing I noticed while testing is that there is a bug in Studio currently where 'randomized' is shown as defaulting to False
in the UI, but on publish, it actually defaults to True
.
If we were actually able to get randomize
to be set to False
on the channel based quiz, it would be good to transfer that to the randomize
attribute when we create a quiz - so that might be the only update I'd make here!
cc @jtamiace @khangmach (as both points above are UX related). Attaching the db.sqlite3 file of my device, if it helps for debugging. |
This certainly seems like a bug - all activity within a facility should be scoped within that facility (there may be a use case for copying a quiz across facilities, but that workflow would only be applicable for a super admin). |
Yes, bumping into this issue is certainly the result of me going through the coach-specific workflow as a superadmin on a device with multiple facilities. When user is signed in as a coach and goes through the steps of the feature, they do not encounter any problems. @sairina, since this is a different (edge case) problem not related to your work on this PR, we may disregard my point 2 above, I'll file a separate issue to document and fix this independently. |
@radinamatic (cc: @khangmach and @jtamiace) - Here's what it currently looks like, and it would only appear for the channels. It's at an |
perfect! |
Looking good, @sairina, although I don't think it's necessary for that sentence to be a heading in this context. H2 could have made sense if the channels below were grouped by some criteria (so each group would have a different H2 heading), but since that's not the case, I don't see semantic heading as warranted here. |
One other thing that we had discussed in the run up to design of the feature was hiding it and reverting to no drop down on the button behaviour in the case there are no channel based quizzes (as it is still a somewhat limited access feature at the moment). We can do the actual toggling post-merge, but would be good to have the original button hidden behind an |
@rtibbles, Does this fix the issue? |
Summary
Created interface for coach user to assign pre-made quizzes (channel-based quizzes) to students like a regular quiz.
References
Addresses #7862
Reviewer guidance
Pre-requisite: make sure a channel-based-quiz is available in your Kolibri instance:
kucap-supamkurap-supamTest to see that a channel test can be selected:
PlanChannelQuizPreviewPage
), check to see that the title of the test matches the title in the toolbar, and that the properties such as "Total questions", "Quiz duration", etc. have populated.Making copies of the quiz (method 1):
Making copies of the quiz (method 2):
PlanChannelQuizPreviewPage
), check to see that the title of the test has an additional(#)
appended to the end, and that the properties such as "Total questions", "Quiz duration", etc. have populated. Note that the number will update depending on how many copies of this test exist.Test to see that the channel quiz can be assigned to students
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)