-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add learning activity bar component #8151
Add learning activity bar component #8151
Conversation
4d4e454
to
7a2e58d
Compare
260c47d
to
7526493
Compare
7526493
to
3651e77
Compare
</template> | ||
<TextTruncator | ||
:text="resourceTitle" | ||
:maxHeight="26" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This magical number seems to work though I am not sure how exactly. Let me know if you see some possible issues with it or have more insight into if this is an appropriate value.
</KLabeledIcon> | ||
|
||
<template #icon> | ||
<KIconButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be a good idea to add EDIT: DoneariaLabel
and tooltip
for the back navigation button but am not sure yet and don't know what the string would look like. See https://learningequality.slack.com/archives/C023DNC5GCX/p1623850266060400.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it may need to be wrapped in router-link
in the future depending on how we'll use the component. I took the simplest way for now thinking that we can update it together with a new prop for the link destination, instead of emitting navigateBack
event if needed. The same applies to some other buttons in the bar that may have some connection to the router.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @MisRob! Manual QA looks good to me, and the code is so easy to read. I love the comments, too. Nice work ✨ 🙂
Summary
Add a new, mobile responsive, learning activity bar component.
Note that connecting the bar to the app is out of the scope of this ticket and that if you follow the testing instructions below it will appear sticky even when it's not supposed to be. It's not related to the new component itself, but rather to
CoreBase
and will need to be resolved when we start connecting new bars to pages. Also, since this PR only adds a component to our library, I didn't update any Gherkin stories at this point.Screenshots
Only the most important states are documented here. Please see Figma designs linked in references to compare to the full specification.
Bar/menu items distribution
Bookmarks
Context
When a resource can't be manually marked as complete
References
Reviewer guidance
I haven't found a better way to test the new bar than hacking
CoreBase
locally as demonstrated here and then navigating to a resource page, for example, "Learn" -> "Channels" -> Select a channel and open a resource from a topic of the channel.yarn install --check-files
to pull the latest KDS version containing learning activities icons./en/
by/ar/
in the URL)Testing checklist
PR process
Reviewer checklist
yarn
andpip
)