Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert SharingPool usage #8081

Merged
merged 3 commits into from
May 12, 2021

Conversation

rtibbles
Copy link
Member

Summary

  • Reverts previous usage of SharingPool to ensure connection teardown
  • Adds a global SQLAlchemy connection tear down instead

References

Reverts one part of #7975 to resolve test issues in another way

Reviewer guidance

Do tests still pass and complete on postgres?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from aronasorman May 12, 2021 19:35
Copy link
Collaborator

@aronasorman aronasorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the NullPool change revert and things are working again 👍🏾

@rtibbles rtibbles force-pushed the sharing_is_not_caring branch from 22afea2 to 59fd472 Compare May 12, 2021 21:25
Augment django_db_setup fixture to add sqlalchemy connection cleanup.
@rtibbles rtibbles force-pushed the sharing_is_not_caring branch from 59fd472 to aebe197 Compare May 12, 2021 23:09
@rtibbles rtibbles marked this pull request as ready for review May 12, 2021 23:20
@rtibbles rtibbles merged commit 9136c7f into learningequality:develop May 12, 2021
@rtibbles rtibbles deleted the sharing_is_not_caring branch May 12, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants